Exclusive XInput event handling #1821
Conversation
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
✅ Deploy Preview for conkyweb canceled.
|
Caellian
changed the title
|
Do you have an ETA on when you might be finished this? I was thinking of cutting a new release in the next few days, but I will wait if you will be done soon. |
I expect within the following 2-3 days. There's a quirk I need to figure out a workaround for (working on that currently), other than that it's pretty much done. The PR doesn't introduce any functionality though, it just switches to a newer event system on X11 - not sure if that plays a role in your decision. |
WIP commit - I broke something and events no longer get reported. On a flip side, valuators can be referenced by either a name string or number id now, use of which is easy to optimize by the compiler. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Added support for changing valuator properties through xorg.conf. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Caellian
force-pushed
the
dev/xinput-event-handling
branch
3 times, most recently
from
54bf801
to
38c27c4
Compare
WIP commit - relative calculation is still off. Calculate relative valuators only once per event and cache results. Switch to finding top-level window before root. This made me reuse virtual root code so I refactored it and made it apply automatically in place of X11 macros. This means that all code in x11.cc will use virtual roots if they exist. Fixed query_x11_windows fallback to exclude windows without WM hints. I believe this is the correct way to ignore windows specific to some special WM functionality. Removed InputEvent and xev_as_input_event as they were being used in only a single place. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Caellian
force-pushed
the
dev/xinput-event-handling
branch
from
38c27c4
to
db70a1b
Compare
Wasn't updated due to implicit reference copy. Now relative seems to work. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
First reported event was being reported with bad computed relative value otherwise. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
|
This commit causes me trouble. With fluxbox as WM, a right click on the root window leads to 3 second delay waiting for the WM right-click menu to appear, with 100% CPU in the meantime. |
|
You can build with Time to install yet another X11 WM... 🚀 |
This commit builds upon #1819 and makes conky use only XInput for mouse events if
BUILD_MOUSE_EVENTSis enabled.This PR makes conky only propagate basic X11 mouse events, because constructing XInput events is a bit tricky (or impossible):